好吧,你可能会让事情变得比他们需要的更困难。该评论并不是为了攻击您,但是无论您使用什么编译器/IDE,都应该左右吐出错误。它的编译结果令人惊讶。评论中的建议很合理。总是,always在您认为您的代码值得信赖之前,请在启用警告的情况下进行编译并修复所有警告。
话虽这么说,但你在某些方面却让自己变得很困难。您应该传递数组和FILE*
指针(或文件名)而不是在函数中硬编码文件名。这使得该功能的用途非常有限。您的使用fgets
正如您现在所知,这是不正确的。此外,在传递数组后,您只需将每个单词(假设每行 1 个)读入数组,同时确保不超过声明的行数。
这是一个简短的示例,将从命令行上给出的文件名(或从stdin
默认情况下)。它利用了一个ternary
运算符接受文件名作为第一个参数或设置fp
to stdin
。尝试一下,如果您有疑问请告诉我:
#include <stdio.h>
#define MAXW 64 /* maximum number of lines to read */
#define MAXC 32 /* longest word in abridged Dict. is 28 char
"Antidisestablishmentarianism" */
size_t getwords (char (*words)[MAXC], FILE *fp);
int main (int argc, char **argv) {
char words [MAXW][MAXC] = {{0}}; /* array to hold words */
size_t nwords = 0; /* number of words read */
size_t i;
/* open argv[1] for reading (default: stdin) */
FILE *fp = argc > 1 ? fopen (argv[1], "r") : stdin;
if (!fp) { /* validate file open */
fprintf (stderr, "error: file open failed '%s'.\n", argv[1]);
return 1;
}
nwords = getwords (words, fp);
if (fp != stdin) fclose (fp); /* close file */
printf ("\n words read from '%s':\n\n",
argc > 1 ? argv[1] : "stdin");
for (i = 0; i < nwords; i++)
printf (" words[%2zu] : %s", i, words[i]);
return 0;
}
/* function to read words, 1 - per line, from 'fp' */
size_t getwords (char (*words)[MAXC], FILE *fp)
{
size_t idx = 0; /* index of words read */
/* read each line in file into words array
note: includes trailing newline character */
while (idx < MAXW && fgets (words[idx], MAXC, fp)) {
idx++;
/* note you should check if chars remain in line */
}
if (idx == MAXW) /* check word count against MAXW */
fprintf (stderr, "warning: MAXW words read.\n");
return idx;
}
Compile
gcc -Wall -Wextra -O3 -o bin/fgets_array_words_fn fgets_array_words_fn.c
输入文件
$ cat dat/captnjack1.txt
This
is
a
tale
Of
Captain
Jack
Sparrow
A
Pirate
So
Brave
On
the
Seven
Seas.
Output
$ ./bin/fgets_array_words_fn dat/captnjack1.txt
words read from 'dat/captnjack1.txt':
words[ 0] : This
words[ 1] : is
words[ 2] : a
words[ 3] : tale
words[ 4] : Of
words[ 5] : Captain
words[ 6] : Jack
words[ 7] : Sparrow
words[ 8] : A
words[ 9] : Pirate
words[10] : So
words[11] : Brave
words[12] : On
words[13] : the
words[14] : Seven
words[15] : Seas.
或阅读自stdin
:
$ ./bin/fgets_array_words_fn <dat/captnjack1.txt
words read from 'stdin':
words[ 0] : This
words[ 1] : is
...